Fix TransferListener callbacks for unknown content length uploads#6898
Merged
alextwoods merged 7 commits intomasterfrom Apr 25, 2026
Merged
Fix TransferListener callbacks for unknown content length uploads#6898alextwoods merged 7 commits intomasterfrom
alextwoods merged 7 commits intomasterfrom
Conversation
davidh44
approved these changes
Apr 23, 2026
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix TransferListener callbacks for unknown content length uploads
Motivation and Context
TransferListener callbacks like transferInitiated and transferComplete were not being called for single part, unknown-content length uploads.
Modifications
Why not set
REPORT_PROGRESS_IN_SINGLE_CHUNKfor this case instead?For unknown content length we don't know ahead of time whether this will be a single chunk or multipart (this decision happens deep in UploadWithUnknownContentLengthHelper after the transfer manager has already set
REPORT_PROGRESS_IN_SINGLE_CHUNK.Testing
Added new unit tests + manual reproduction of issue.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License